Changeset 169

Timestamp:

07/06/07 09:56:11 (16 years ago)

Author:

bas

Message:

email2trac.py.in:

• Implemented full ticket field updates via email subject line, see ticket #7

File:

• trunk/email2trac.py.in (modified) (3 diffs)

trunk/email2trac.py.in

@@ -390 +390 @@
                         try: 
                                 index, value = string.split(field,'=')
+
+                                # We can not change the description of a ticket via the subject
+                                # line. The description is the body of the email
+                                #
+                                if index.lower() in ['description']:
+                                        continue
+
                                 if value:
                                         result[index.lower()] = value
+
                         except ValueError:
                                 pass
@@ -397 +405 @@
                 return result
 
-        def update_ticket_fields(self, system_fields, user_fields): 
-                for field in system_fields:
-                        print field['name']
+        def update_ticket_fields(self, ticket, user_dict): 
+                """
+                This will update the ticket fields when supplied via 
+                the subject mail line. It will only update the ticket 
+                field:
+                        - If the field is known
+                        - If the value supplied is valid for the ticket field
+                        - Else we skip it and no error is given
+                """
+
+                # Build a system dictionary from the ticket fields 
+                # with field as index and option as value
+                #
+                sys_dict = dict()
+                for field in ticket.fields:
                         try:
-                                print field['options']
+                                sys_dict[field['name']] = field['options']
+
                         except KeyError:
-                                print field
+                                sys_dict[field['name']] = None
                                 pass
+
+                # Check user supplied fields an compare them with the
+                # system one's
+                #
+                for field,value in user_dict.items():
+                        if self.DEBUG >= 5: 
+                                print  'user field : %s=%s' %(field,value)
+
+                        if sys_dict.has_key(field):
+                                if self.DEBUG >= 5: 
+                                        print  'sys field  : ', sys_dict[field]
+
+                                # Check if value is an allowed system option, if TypeError then
+                                # every value is allowed
+                                #
+                                try:
+                                        if value in sys_dict[field]:
+                                                ticket[field] = value
+
+                                except TypeError:
+                                        ticket[field] = value
+                                        
+                                
                                 
         def ticket_update(self, m):
@@ -459 +503 @@
                                 return False
 
-                        # Must we update some ticket fields
-                        #
-                        self.update_ticket_fields(tkt.fields, update_tkt_fields)
-                        sys.exit(1)
-
-                        for key,value in tkt_fields.items():
-                                tkt[key] = value
+                        # Must we update some ticket fields properties
+                        #
+                        self.update_ticket_fields(tkt, update_tkt_fields)
 
                         tkt.save_changes(self.author, body_text, when)