Changeset 319


Ignore:
Timestamp:
02/22/10 15:13:34 (11 years ago)
Author:
bas
Message:

When there a problems with saving attachments. Show it as comment in the ticket, closes #165

Location:
trunk
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/debian/changelog

    r316 r319  
    1313    Applied by: Bas van der Vlies
    1414
    15   * Fixed a bug when there is no subject line in the message, closes #179
     15  * Fixed a bug when there is no subject field in the message, closes #179
    1616    Reported by: xurizaemon
    1717    Fixed by: Bas van der Vlies
     18
     19  * Added unicode support attachment filenames, closes #177
     20    Reported by: obwandner add concertare dot de
     21    Fixed by: Bas van der Vlies
     22
     23  * Email to blog did not work at all. It works but it can not handle
     24    attachments. see #175.
     25    Reported by: oland dot wells add gmail.com
     26    Patches    : Bas van der Vlies
    1827   
    1928 -- Bas van der Vlies <basv@sara.nl>  Wed, 27 Jan 2010 16:17:41 +0100
  • trunk/email2trac.py.in

    r318 r319  
    927927                ## Save the attachments to the ticket   
    928928                #
    929                 has_attachments =  self.attachments(message_parts)
    930 
    931                 #  Disabled
    932                 #if has_attachments:
    933                 #       changed = True
    934                 #       comment = '%s\n%s\n' %(comment, has_attachments)
     929                error_with_attachments =  self.attachments(message_parts)
     930
     931                if error_with_attachments:
     932                        changed = True
     933                        comment = '%s\n%s\n' %(comment, error_with_attachments)
    935934
    936935                if changed:
     
    15081507                #
    15091508                max_size = int(self.get_config('attachment', 'max_size'))
    1510                 status   = ''
     1509                status   = None
    15111510               
    15121511                for part in message_parts:
     
    15641563                        os.unlink(path)
    15651564
    1566                 # Return how many attachments
    1567                 #
    1568                 status = 'This message has %d attachment(s)\n%s' %(count, status)
     1565                ## return error
     1566                #
    15691567                return status
    15701568
Note: See TracChangeset for help on using the changeset viewer.