Changeset 398

Timestamp:

07/15/10 14:04:11 (14 years ago)

Author:

bas

Message:

Added permission check system, closes #202, #203.

• can be activated by setting ticket_permission_system:
  • ticket_permission_system: trac
  • ticket_permission_system: update_restricted_to_participants

If it is set to trac it will honour the settings that are set in the trac system.

If 'update_restricted_to_participants' is choosen then a ticket update is allowed only if:

1) the updater is the reporter,
2) the updater is in the CC
3) the updater has trac permission to update the ticket.

If the update is denied, a new ticket will be generated instead as to not loose the issue .

File:

• trunk/email2trac.py.in (modified) (5 diffs)

trunk/email2trac.py.in

@@ -663 +663 @@
 ########## TRAC ticket functions  ###########################################################
 
-        def check_permission(self, action):
+        def check_permission_participants(self, tkt):
+                """
+                Check if the mailer is allowed to update the ticket
+                """
+
+                if tkt['reporter'].lower() in [self.author, self.email_addr]:
+                        if self.DEBUG:
+                                print 'ALLOW, %s is the ticket reporter' %(self.email_addr)
+                        return True
+
+                perm = PermissionSystem(self.env)
+                if perm.check_permission('TICKET_MODIFY', self.author):
+                        if self.DEBUG:
+                                print 'ALLOW, %s has trac permission to update the ticket' %(self.author)
+                        return True
+                else:
+                        return False
+                
+
+                # Is the updater in the CC?
+                try:
+                        cc_list = tkt['cc'].split(',')
+                        for cc in cc_list:
+                                if self.email_addr.lower() in cc.strip():
+
+                                        if self.DEBUG:
+                                                print 'ALLOW, %s is in the CC' %(self.email_addr)
+
+                                        return True
+
+                except KeyError:
+                        return False
+
+        def check_permission(self, tkt, action):
                 """
                 check if the reporter has the right permission for the action: 
@@ -678 +711 @@
 
                 if self.TICKET_PERMISSION_SYSTEM in ['trac']:
+
                         perm = PermissionSystem(self.env)
                         if perm.check_permission(action, self.author):
@@ -683 +717 @@
                         else:
                                 return False
+
+                elif self.TICKET_PERMISSION_SYSTEM in ['update_restricted_to_participants']:
+                        if action in ['TICKET_MODIFY']:
+                                return (self.check_permission_participants(tkt))        
+                        else:
+                                return True
+
+                # Default is to allow everybody ticket updates and ticket creation
                 else:
                                 return True
@@ -810 +852 @@
                         return False
 
+                # Check the permission of the reporter
+                #
+                if self.TICKET_PERMISSION_SYSTEM:
+                        if not self.check_permission(tkt, 'TICKET_MODIFY'):
+                                print 'Reporter: %s has no permission to modify tickets' %self.author
+                                return False
+
                 # How many changes has this ticket
                 cnum = len(tkt.get_changelog())
@@ -1015 +1064 @@
                 #
                 if self.TICKET_PERMISSION_SYSTEM:
-                        if not self.check_permission('TICKET_CREATE'):
+                        if not self.check_permission(tkt, 'TICKET_CREATE'):
                                 print 'Reporter: %s has no permission to create tickets' %self.author
                                 return False