Changeset 654

Timestamp:

04/24/14 22:01:07 (10 years ago)

Author:

bas

Message:

fixed format-security problem, closes #341
fixed Typo in variable assignment, closes #342

Location:

trunk

Files:

• ChangeLog (modified) (2 diffs)
• debian/changelog (modified) (1 diff)
• email2trac.py.in (modified) (2 diffs)
• email2trac.spec (modified) (1 diff)
• run_email2trac.c (modified) (1 diff)

trunk/ChangeLog

@@ -1 @@
-2.8.1
+2.8.4
   * There was a case where the lower method on a string was referenced as an object instead of 
     actually making a method call, closes #340
@@ -9 +9 @@
     Applied by: Bas van der Vlies
 
-  * 
+  * fixed a format-security problem in run_email2trac.c, closes #341
+    Author: thomasdot moschny@gmx dot de
+    Applied by: Bas van der Vlies
+
+  * fixed Typo in variable assignment, closes #342
+    Author: Anonymous
+    Applied by: Bas van der Vlies
+
 2.8.0
   * Also made delete_spam virtual env aware

trunk/debian/changelog

@@ -1 @@
-email2trac (2.8.1-1) stable; urgency=low
+email2trac (2.8.4-1) stable; urgency=low
 
   * See Changelog 

trunk/email2trac.py.in

@@ -718 +718 @@
         """
         To bypass a bug in Trac
-        check if the filename lenght is not larger then OS limit.
+        check if the filename length is not larger then OS limit.
           yes : return truncated filename
           no  : return unmodified filename
@@ -740 +740 @@
             quote_format = util.text.unicode_quote(dummy_filename)
 
-        ## Determine max filename lenght
+        ## Determine max filename length
         # 
         try:
             filemax_length = os.pathconf('/', 'PC_NAME_MAX')
         except AttributeError, detail:
-            filemax_lenght = 240
+            filemax_length = 240
 
         if len(quote_format) <= filemax_length:

trunk/email2trac.spec

@@ -1 +1 @@
 Summary: Utilities for converting emails to trac tickets
 Name: email2trac
-Version: 2.8.1
+Version: 2.8.4
 Release: 1
 License: Apache License 2.0

trunk/run_email2trac.c

@@ -57 +57 @@
 {
     openlog("run_email2trac", LOG_PID, LOG_MAIL); 
-    syslog(LOG_ERR, message);
+    syslog(LOG_ERR, "%s", message);
     closelog();
 }