Custom Query (332 matches)

Hi Bas,

The attached patch fixes a bug when updating a ticket, in the case where the user submitting the update has Trac permission TICKET_MODIFY, but not TICKET_APPEND or TICKET_CHGPROP. This causes the ticket update to fail.

Since Trac documentation states that TICKET_MODIFY includes TICKET_APPEND and TICKET_CHGPROP permissions, I changed email2trac to check for TICKET_MODIFY whenever it checks for one of the other two permissions.

I also matched Trac behavior with respect to logging, so that when logging to file or stderr without an explicit log_format, a timestamp precedes the log message.

And I changed the log line that reports the subject of the email from 'debug' to 'info' so that in the case of success, there would be at least one line in the log file to indicate that email2trac processed that email.

Hope this helps.

Dennis McRitchie?

Hello email2trac-devs

It seems that email2trac is platform-agnostic, and certainly not
limited
to i386. I therefore propose the following patch:

Index: debian/control
===================================================================
--- debian/control      (revision 196)
+++ debian/control      (working copy)
@@ -7,7 +7,7 @@

  Package: email2trac
  Section: misc
-Architecture: i386
+Architecture: all
  Maintainer: Bas van der Vlies <bas@sara.nl>
  Depends: ${slibs:Depends}, python, cdbs, trac
  Description: Converts email to a trac ticket

I tried to use a modified copie of /usr/lib/python2.4/site-packages/Trac-0.11-py2.4.egg/trac/ticket/templates/ticket_notify_email.txt as template for the initial notification to the reporter. This copy is placed in the same directory an specified in email2trac.conf

project: /home/trac/ticket
debug: 1
umask: 022
spam_level: 5
reply_all : 0
mailto_link: 0
umask: 022
email_header: 0
trac_version: 0.11
enable_syslog: 1
alternate_notify_template: new_notify.txt
drop_spam: 0
verbatim_format: 0
strip_signature: 1
email_quote: >
strip_quotes: 1
ignore_trac_user_settings: 0
ticket_update: 1
blacklist: MAILER-DAEMON@

Trac-notification and reporter-notification is enabled, but always ticket_notify_email.txt is used as template.

[notification]
always_notify_owner = true
always_notify_reporter = true
always_notify_updater = false
mime_encoding = base64
nevernotifyupdater = true
reporter_states = new,closed,reopened
smtp_always_bcc = hju@jochenkuhl.de
smtp_always_cc = 
smtp_default_domain = 
smtp_enabled = true
...

I've browsed the source to find the clue, but I found no bug. As I anderstood, the "standard-process" of notification is used to get_recipients. Therefore it is no additional notification sent but the replacement of the normal notification depending on the settings for notification (means: if always_notify_reporter = false there will never be a notification send to reporter.

Did I miss anything in the manual?

Is there any hidden option to enable it?