Custom Query (332 matches)
Results (151 - 153 of 332)
Ticket | Resolution | Summary | Owner | Reporter |
---|---|---|---|---|
#201 | fixed | [Trac] - email2trac for trac 0.12 | bas | mark_kids@… |
Description |
Hi Sara, I've tried installing the latest version of email2trac. But unfortunately, it failed on testing. My trac version is currently 0.12dev. I've ran this and I got a message thats says it's not supported. # email2trac --project=affinity < /usr/local/src/email2trac-1.4.2/msg.txt TRAC version 0.12dev is not supported Thanks and regards, Mark |
|||
#202 | fixed | email2trac does not honor Trac permissions when creating/updating tickets | bas | Dennis McRitchie <dmcr@…> |
Description |
Hi Bas, I love this script, and am increasingly using it with our Trac projects; however, one problem is that it does not appear to respect the Trac permissions set up for creating or updating tickets. This seems to happen whether the reporter is "anonymous" (in which case, I would expect it to respect the permissions assigned to "anonymous"), as well as when the reporter has an email address that can be translated into one of the known users (where I would expect email2trac to respect the permissions for that user). As it is, email2trac will create a ticket for anyone, even if that person could not create a ticket if they went to the Trac website and tried to do it from there. I would think the two methods should be consistent. Is this intentional, or just something you have not had time to get around to yet? Or worse still, does Trac not support a way of finding out the permissions using its API? Thanks,
P.S. I'm actually using 1.4.2, which is not on the Version drop-down list. |
|||
#203 | fixed | [PATCH]: Allow restricting ticket updates to ticket participants | bas | kris@… |
Description |
USE CASE: I use email2trac to integrate an internal instance of Trac with traditional user support ticketing via email. This is great, because it keeps both internal and external issues under the same roof. Users simply send in their support requests via e-mail and email2trac + Trac notifications handle the rest while keeping Trac itself restricted. [ Parenthetically, by use of tags and an outgoing filter in the MTA, external tickets can also have internal comments allowing us to define which updates are to be sent out externally. This would of course be better to implement in the Trac layer, but it does the job. ] PROBLEM: With ticket_update on, email2trac allows any ticket to be updated by just changing the ticket number in the Subject. While great for an open Trac, it opens a security hole when Trac is used for private ticketing. Example:
PATCHED BEHAVIOR: by turning on ticket_update_restricted_to_participants, a ticket update is allowed only if 1) the updater is the reporter, 2) the updater is in the CC or 3) the updater matches a Trac username (i.e. is staff). If the update is denied, a new ticket will be generated instead as to not loose the issue (NOTE: the current trunk will drop any e-mail that has a ticket number which does not match a ticket; this patch also fixes that as a side-effect). Index: email2trac.py.in =================================================================== --- email2trac.py.in (revision 375) +++ email2trac.py.in (working copy) @@ -197,6 +197,11 @@ else: self.TICKET_UPDATE = 0 + if parameters.has_key('ticket_update_restricted_to_participants'): + self.TICKET_UPDATE_RESTRICTED_TO_PARTICIPANTS = int(parameters['ticket_update_restricted_to_participants']) + else: + self.TICKET_UPDATE_RESTRICTED_TO_PARTICIPANTS = 0 + if parameters.has_key('ticket_update_by_subject'): self.TICKET_UPDATE_BY_SUBJECT = int(parameters['ticket_update_by_subject']) else: @@ -762,6 +767,42 @@ self.id = None return False + + if self.TICKET_UPDATE_RESTRICTED_TO_PARTICIPANTS: + + # Is the updater the reporter? + # Since all Trac users are allowed to update, it does + # not matter if any of our fields contain usernames + # instead of emails. + # + if tkt['reporter'] and self.email_addr.lower() == tkt['reporter'].lower(): + if self.DEBUG: + print 'Restricted update: ALLOW, %s is the ticket reporter' %(self.email_addr) + + # Is the updater in the CC? + elif tkt['cc'] and self.email_addr.lower() in tkt['cc'].lower().replace(' ', '').split(','): # assuming space is fragile, hence replace() + if self.DEBUG: + print 'Restricted update: ALLOW, %s is in the CC' %(self.email_addr) + + else: + tkt_allow_update = False + + # Is the update a Trac user? + for username, name, email in self.env.get_known_users(): + if email and email.lower() == self.email_addr.lower(): + tkt_allow_update = True + if self.DEBUG: + print 'Restricted update: ALLOW, %s matches username %s' %(self.email_addr, username) + break + + # No luck? Fail the update. + if not tkt_allow_update: + if self.DEBUG: + print 'Restricted update: DENIED, %s does not match a username nor is it the reporter or in the CC' %(self.email_addr) + self.id = None + return False + + # How many changes has this ticket cnum = len(tkt.get_changelog()) @@ -1486,7 +1527,11 @@ # if result.group('reply') and self.TICKET_UPDATE: self.system = 'ticket' - self.ticket_update(m, result.group('reply'), spam_msg) + result = self.ticket_update(m, result.group('reply'), spam_msg) + + # If the ticket was not found, create a new one instead of loosing it + if not result: + self.new_ticket(m, subject, spam_msg) # New ticket + fields # Looking forward to seeing whether you think this is something that should go into the release. The patch itself is rather verbose due to the debugging. FWIW this was also my first foray into Python, apologies if the patch is not very Pythonic. :) Thanks a lot for your efforts, keep up the great work!
|