Custom Query (332 matches)

In our syslogs we have been seeing this error:

Oct 22 04:02:22 sun email2trac: Traceback (most recent call last): Oct 22 04:02:22 sun email2trac: File "/usr/local/email2trac/bin/email2trac", line 1240, in <module> tktparser.parse(sys.stdin) Oct 22 04:02:22 sun email2trac: File "/usr/local/email2trac/bin/email2trac", line 818, in parse self.new_ticket(m, spam_msg) Oct 22 04:02:22 sun email2trac: File "/usr/local/email2trac/bin/email2trac", line 719, in new_ticket self.set_reply_fields(tkt, msg) Oct 22 04:02:22 sun email2trac: File "/usr/local/email2trac/bin/email2trac", line 458, in set_reply_fields if mail_list: Oct 22 04:02:22 sun email2trac: UnboundLocalError?: local variable 'mail_list' referenced before assignment

Connected to these issue we get errors similar to: Oct 24 04:02:20 sun sendmail[20474]: m9O8279H020473: to="|/usr/local/email2trac/bin/run_email2trac --project=PNIInternal --component=Tesla", ctladdr=<tesla-help@…> (47/0), delay=00:00:13, xdelay=00:00:13, mailer=prog, pri=60635, dsn=2.0.0, stat=Sent Oct 24 04:02:20 sun sendmail[20474]: m9O8279H020473: to=<lewing@…>, delay=00:00:13, xdelay=00:00:00, mailer=esmtp, pri=60635, relay=emfw4.xxxx.zzz. [128.112.131.23], dsn=2.0.0, stat=Sent (Ok: queued as A547D904E00)

This is causing some of our emails to not be processed into the ticket system.

We think it's because these are emails being generated en-masse to notify us and users of their ID's expiring. It could be a timing or threading issue but we arn't quite sure what's going on.

If you have any testing or suggestions we welcome them as this needs to be fixed.

If a blank email is sent with just an attachment, a blank comment is appended to the comments.

​Line 630@email2trac.py

I seem to have alleviated this issue by simply changing that line to:

if body_text.strip():
     tkt.save_changes(self.author, body_text, when)

I started to port this script for trac 0.11 and I founded two errors.

The first is in the notify method and it is described in the #34 ticket. The solution, for me, was to remove the hack.

# create false {abs_}href properties, to trick Notify()
#
self.env.abs_href = Href(self.get_config('project', 'url'))
self.env.href = Href(self.get_config('project', 'url'))

The env members(abs_href and href) don't need to be overwritten.

The second problem was that in ticket_modify method. When saving the modifications made on a ticket it was passed an integer as the modification time.

Traceback (most recent call last):
  File "/home/andrei/workspace/etf/trunk/share/bin/email2trac.py", line 1062, in ?
    tktparser.parse(file('/tmp/tests/tm.eml', 'r'))
  File "/home/andrei/workspace/etf/trunk/share/bin/email2trac.py", line 663, in parse
    if self.ticket_update(m):
  File "/home/andrei/workspace/etf/trunk/share/bin/email2trac.py", line 542, in ticket_update
    tkt.save_changes(self.author, body_text, when)
  File "/home/andrei/workspace/etf/trunk/vendor/trac-0.11dev/trac/ticket/model.py", line 207, in save_changes
    when_ts = to_timestamp(when)
  File "/home/andrei/workspace/etf/trunk/vendor/trac-0.11dev/trac/util/datefmt.py", line 55, in to_timestamp
    diff = dt - _epoc
TypeError: unsupported operand type(s) for -: 'int' and 'datetime.datetime'

In trac 0.11 if the modification time is None then datetime.now() is assumed. So the solution is to send a None.

A patch is attached.