Custom Query (332 matches)

After Fetching a Mail, with email2trac we have sometimes following Problem with the filename of the attachments:

=?iso-8859-1?Q?Erl=E4uterung=2Epdf?= should by named as Erläuterung.pdf

Mail send by MS-Outlook of Exchange to postfix the fetch by fetchmail email2trac on a Debian Machine.

Looking at a solution for our problems in #176 I traced down to the real cause.

Normaly we don't want to inform the updater with any notification. Also the reporter should get infos only if the ticket is closed (we don't want to bother him with all the steps towards this)

There is only one difference: if the reporter has sent an email and the ticket is created by email2trac, he should get a confirmation with the ticket number.

So the question was: how to separate notifications for "normal tickets" from notifications for tickets via email2trac.

I took the easy way. Separate it at the root - in email2trac itself.

I wrote some lines of code to achive a notification triggered by email2trac regardeless the configuration of trac.ini (see attachment)
(This might be enhanced with options for email2trac.conf, if necessary)
It's a "quick hack" and perhaps not in high sophisticated python, but is works. I let trac do the whole work and insert the email of the sender just before mailing the ticket...

--- email2trac_1.0.0	2009-09-02 10:57:42.000000000 +0200
+++ email2trac_1_0_0_new	2010-02-12 20:08:43.000000000 +0100
@@ -85,11 +85,13 @@
 
 from datetime import tzinfo, timedelta, datetime
 from trac import config as trac_config
+import trac.notification as TracNotification
 
 # Some global variables
 #
 trac_default_version = '0.11'
 m = None 
+sender_email = ''
 
 # A UTC class needed for trac version 0.11, added by
 # tbaschak at ktc dot mb dot ca
@@ -435,6 +437,7 @@
 		"""
 		Get the default author name and email address from the message
 		""" 
+		global sender_email
 
 		self.email_to = self.email_to_unicode(message['to']) 
 		self.to_name, self.to_email_addr = email.Utils.parseaddr (self.email_to) 
@@ -445,6 +448,7 @@
 		# Trac can not handle author's name that contains spaces
 		#
 		self.author = self.email_addr
+		sender_email = self.email_addr
 
 		if self.IGNORE_TRAC_USER_SETTINGS:
 			return

This following block is not really part of the patch, but it removes unecessary changelog-entrys for new tickets (i used them as workaround). (may be skipped)

@@ -824,7 +828,6 @@
 		#
 		if self.notify_template:
 			tkt['id'] = self.id
-			changed = True
 
 		# Rewrite the description if we have mailto enabled
 		#
@@ -1451,8 +1454,9 @@
 			fd.close()
 			os.unlink(path)
 
-		# Return how many attachments
+		# Return how many attachments if > 0 or problems with attachment size
 		#
+		if status or count > 0:
 			status = 'This message has %d attachment(s)\n%s' %(count, status)
 		return status

here comes the little wrapper:

@@ -1499,6 +1503,22 @@
 
 	return project
 
+def WrapNotify(self, resid):
+	"""
+	Copy of def notify() to manipulate recipents 
+	"""
+	(torcpts, ccrcpts) = self.get_recipients(resid)
+	
+	# additionally append sender (regardeless of settings in trac.ini)
+	#
+	torcpts.append(sender_email)
+
+	self.begin_send()
+	self.send(torcpts, ccrcpts)
+	self.finish_send()
+
+TracNotification.Notify.notify = WrapNotify
+
 
 if __name__ == '__main__':
 	# Default config file

If an email with a blank subject is submitted, the following error occurs (from my syslog):

Feb 15 03:05:22 mohua email2trac: Traceback (most recent call last):
Feb 15 03:05:22 mohua email2trac:   File "/usr/bin/email2trac", line 1642, in <module>#012    tktparser.parse(sys.stdin)
Feb 15 03:05:22 mohua email2trac:   File "/usr/bin/email2trac", line 961, in parse#012    m.replace_header('Subject', m['Subject'].replace('\r', '').replace('\n', ''))
Feb 15 03:05:22 mohua email2trac: AttributeError: 'NoneType' object has no attribute 'replace'

I can't find the subject requirement documented, except obliquely (?) in response to #124.

If a site expected error output without a subject (eg some_cmd.sh | mail trac@example.org) to be handled by email2trac, this could be a nasty gotcha for them when those errors weren't turned into incoming tickets.

Testing for subject and inserting a default one would be a more graceful solution than the current exit.

Using Email2Trac $Id: email2trac.py.in 305 2010-01-11 15:09:54Z bas $