Embedded images in emails

[martin.poeschmann@…]

When sending an email with an embedded image (from outlook in my case), the resulting attachment to the ticket is too small.

I changed line 1115 to: # Insert the attachment # fd = open(path, 'rb' )

Because Outlook sets the minetype to image/jpg the following change has to be made: line 1061: ext = mimetypes.guess_extension(part.get_content_type(),False)

[cc@…]

This is the author of comment:ticket:93:1. Martin, your suggestion has done the trick for us. Binary attachments are now working correctly. Thanks for the fix!

The line numbers from Martin's comment may be off depending on the version of the script and whether your copy has been customized at all. We just searched for the original snippets and modified them to match the modified snippets.

Original Snippet 1:

# Insert the attachment
# 
fd = open(path)

Modified Snipped 1 (matching Martin's description):

# Insert the attachment
# 
fd = open(path, 'rb')

Original Snippet 2:

ext = mimetypes.guess_extension(part.get_content_type())

Modified Snippet 2 (matching Martin's description):

ext = mimetypes.guess_extension(part.get_content_type(), False)

[bas]

Thanks for the patch and suggestion. I will into it when i am back from holidays

[bas]

I applied the patch to trunk

[bas]

will release new version