Modify

Opened 12 years ago

Closed 12 years ago

#149 closed defect (fixed)

filenames of attachments are escaped twice by email2trac

Reported by: hju@… Owned by: bas
Priority: minor Milestone: Release 1.1.0
Component: email2trac Version: 1.0.0
Keywords: Cc:

Description

If email2trac creats a ticket whith an attachment having a space in the filename, the filename is excaped twice.

example (see also attached screenshots): test 1.txt is named test%201.txt and stored as test%25201.txt bei email2trac.

if you add an attachment via webclient, the filename is only escaped once: test 2.txt is named test 2.txt and stored as test%202.txt

Also trac has no problem to find the file, we encountered this using a script (AdvancedTicketWorkflow? - run_external) to find the attachments with the filenames stored in the database. We had to work around this bei again escaping the filename stored in database.

It's not a serious bug while trac gets around it, but annoying and of course different from the "normal" trac behaviour.

Attachments (2)

name_in_ticket.jpg (14.8 KB) - added by hju@… 12 years ago.
filename_on_server.jpg (12.3 KB) - added by hju@… 12 years ago.

Download all attachments as: .zip

Change History (10)

Changed 12 years ago by hju@…

Changed 12 years ago by hju@…

comment:1 Changed 12 years ago by bas

  • Status changed from new to assigned
  • Version changed from 0.3 to 1.0.0

I will test it. There is a parameter that isnot yet described on the website:

  • quote_attachment_filenames

Can you set that to 0 and test it again?

see ticket #138

comment:2 Changed 12 years ago by bas

Or do you realy run version 0.3?

comment:3 follow-up: Changed 12 years ago by bas

Does this work?

comment:4 in reply to: ↑ 3 Changed 12 years ago by hju@…

Replying to bas:

Does this work?

Sorry, we are still on 0.3 (r218) so I couldn't test it till now (not implemented). Our "workaround" is still running...

The correct answer is: I don't know yet.

I'll have a look after updating - perhaps in the cold winter days...

comment:5 Changed 12 years ago by hju@…

After updating to 1.0.0 the behaviour ist still the same - sorry fot the bad news

comment:6 Changed 12 years ago by bas

(In [296]) email2trac.py.in:

  • Fixed an error when adding attachments with filenames that needed to be escaped, see #149

comment:7 Changed 12 years ago by bas

  • Milestone set to Release 1.1.0

comment:8 Changed 12 years ago by bas

  • Resolution set to fixed
  • Status changed from assigned to closed

Il will release a new verion. So i close it

Add Comment

Modify Ticket

Change Properties
Action
as closed The owner will remain bas.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.