Modify

Opened 11 years ago

Closed 8 years ago

#154 closed enhancement (fixed)

[Patch] strip_signature and strip_quotes more effective

Reported by: hju@… Owned by: bas
Priority: major Milestone: strip signature/quotes
Component: email2trac Version: trunk
Keywords: Cc:

Description

Both options had no effekt in our environment (trac 0.11, email2trac 0.30)

Signatures where not effected at all.

If you use the "reply" option with setting "Text der ursprünglichen Nachricht beifügen" in outlook (don't know the english version of this outlook option), mails are getting longer and longer making the comments very difficult to read.

The attached patch solves this for me.

Attachments (1)

email2trac.diff.patch (647 bytes) - added by hju@… 11 years ago.
patch for email2trac.py def strip_signature and def strip_quotes

Download all attachments as: .zip

Change History (6)

Changed 11 years ago by hju@…

patch for email2trac.py def strip_signature and def strip_quotes

comment:1 Changed 11 years ago by bas

  • Status changed from new to assigned

Thanks for the patch. I have to examine this patch especially the strip signature change. It will break the UNIX mailers

comment:2 Changed 11 years ago by hju@…

Perhaps there is a more general pattern for strip_signature. I took this string to let -----Ursprüngliche Nachricht----- pass if strip_quote is disabled...

comment:3 Changed 11 years ago by bas

  • Milestone set to strip signature/quotes

comment:4 Changed 8 years ago by bas

One part of your patch is covered by a new configuration option:

  • strip_signature_regex, see Changeset [606]

comment:5 Changed 8 years ago by bas

  • Resolution set to fixed
  • Status changed from assigned to closed

The other part also. You only have to add to email_quote regex:,

 	826	                        if line.find('------')<> -1 or line.find('______')<> -1: 
 	827	

Maybe i have to rename the options to

  1. skip line but still parse the rest of the message
  2. skip line and stop parsing

Add Comment

Modify Ticket

Change Properties
Action
as closed The owner will remain bas.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.