workflow option is ignored (patch)

[thomas.moschny@…]

In order to avoid closed tickets being reopened by email2trac, I configured 'workflow: leave', but that didn't work at first. The following patch was needed.

--- email2trac-1.0.0/email2trac.py.in.orig	2009-09-02 10:57:42.000000000 +0200
+++ email2trac-1.0.0/email2trac.py.in	2009-10-21 15:40:53.000000000 +0200
@@ -660,7 +660,7 @@ class TicketEmailParser(object):
 			#b = controller.get_ticket_changes(req, tkt, 'reopen')
 			#print 'get_ticket_changes :', b
 
-			if self.WORKFLOW and (self.VERSION in ['0.11']) :
+			if self.WORKFLOW and self.VERSION == 0.11:
 				from trac.ticket.default_workflow import ConfigurableTicketWorkflow
 				from trac.test import Mock, MockPerm
 

In the long run, it might be a better idea to turn self.VERSION into a string.

[bas]

thanks for the fix. Can you try the following patch:

if self.WORKFLOW and (self.VERSION in [0.11]) :

It must be an integer.

[thomas.moschny@…]

Replying to bas:

thanks for the fix. Can you try the following patch:

if self.WORKFLOW and (self.VERSION in [0.11]) :

Yes, that also works.

It must be an integer.

Why's that? If sorting is an issue, any variant of natsort works, or distutils.version.

[bas]

email2trac supports different version of Trac and we use this to determine which API function must be used for the different trac version. It use a lot in the code.

[bas]

(In [288]) email2trac.py.in:

• workflow patch, did not work, closes #157
• When i ticket is updated we did supply all need fields, like ticket change number, closes #156

debian/changelog:

• new list of changes