Modify

Opened 11 years ago

Closed 11 years ago

#171 closed enhancement (fixed)

Specify ticket properties in message body

Reported by: samuel@… Owned by: bas
Priority: major Milestone: Version 1.2
Component: email2trac Version:
Keywords: Cc:

Description

I have found it annoying to specify ticket attributes in the subject of an email. It would be nice if it was possible to specify ticket attributes in the message body, in stead.

Another disadvantage of specifying ticket attributes in the message subject is that unintentional ticket attribute modifications are likely when replying to a previous "email2trac" email. Specifying them in the message body eliminates this possibility.

Attachments (2)

inline_properties.diff (1.1 KB) - added by samuel@… 11 years ago.
A possible implementation, using the syntax "@attribute: value"
inline_properties.2.diff (3.0 KB) - added by samuel@… 11 years ago.

Download all attachments as: .zip

Change History (11)

Changed 11 years ago by samuel@…

A possible implementation, using the syntax "@attribute: value"

comment:1 Changed 11 years ago by bas

  • Resolution set to duplicate
  • Status changed from new to closed

First some explanation the subject line is never updated!. When you send a email with some subject modifications to change some ticket fiolds and notification is enabled You only get an email with the orginal ticket summary line and what is changed.

With inline ticket fields changing we have to parse the the text and strip it to avoid the problems tou mentioned.

and it is a duplicate, see #114

comment:2 Changed 11 years ago by anonymous

  • Resolution duplicate deleted
  • Status changed from closed to reopened
  • Type changed from defect to enhancement

This is not the same as #114; perhaps I didn't explain this well enough. This feature request is about allowing ticket attributes to be updated using the message body.

For example, in stead of replying to a ticket with the subject line:

Subject: [bas] #171?resolution=duplicate&status=closed: ...

It would be possible to specify something like the following in the message body:

@status: closed @resolution: duplicate

The previously attached patch provides a working implementation of the feature request using the above syntax.

comment:3 Changed 11 years ago by bas

#114 also mentioned this, but another syntax. I have looked at the patch and i miss the inline_properties function. Does this function filter and strip the above mentioned syntax?

Thanks for the patch, I did not noticed it the first time :-(

Changed 11 years ago by samuel@…

comment:4 Changed 11 years ago by samuel@…

My apologies; it appears the patch was cut off the first time around. I have attached the entire patch, now.

The patch includes a function "strip_inline_properties" that filters & strips the above mentioned syntax.

comment:5 Changed 11 years ago by bas

  • Version 1.0.0 deleted

Thanks, i will apply it, maybe with some minor modifications

comment:6 Changed 11 years ago by bas

  • Milestone set to Version 1.2

comment:7 Changed 11 years ago by bas

Samuel i just review the patch and have i question? Why do you parse the message again? If we just add your function to:

  • get_message_parts()

We can set the tickets fields and strip the text at the same time + if we compile the regex string is also much quicker.

comment:18 Changed 11 years ago by samuel@…

Parsing the message again seemed like the simplest solution at the
time, and
I wasn't too concerned about efficiency. I don't see a problem with
adding
the function to get_message_parts(). Feel free to change this.


On Wed, Jan 27, 2010 at 11:04 AM, email2trac <email2trac@sara.nl>
wrote:

comment:9 Changed 11 years ago by bas

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [309]) email2trac.py.in:

  • added inline properties patch. To set ticket fields within an email, eg:

@owner: bas

Will set the owner of the ticket to bas, closes #171

  • Display a warning if it is a blog message and the plugin is not installed, see #175

Add Comment

Modify Ticket

Change Properties
Action
as closed The owner will remain bas.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.