Modify

Opened 11 years ago

Closed 11 years ago

#196 closed defect (fixed)

The usage of a slash ( / ) in subjects is not permitted when forwarding

Reported by: jcuppen@… Owned by: bas
Priority: blocker Milestone: 1.4.0
Component: email2trac Version: trunk
Keywords: Cc:

Description

The slash is occurring to be an directory slash

  • Tested version is email2trac-1.1.0

Attachments (3)

Undelivered Mail Returned to Sender.eml (6 bytes) - added by jcuppen@… 11 years ago.
Added by email2trac
None (6 bytes) - added by jcuppen@… 11 years ago.
Added by email2trac
None-1 (6 bytes) - added by jcuppen@… 11 years ago.
Added by email2trac

Download all attachments as: .zip

Change History (17)

comment:1 Changed 11 years ago by bas

  • Status changed from new to assigned

Thanks for reporting. I will test it. Waht do you mean with forwarding? Can i just test it with a / in the subject of an email.

comment:2 Changed 11 years ago by jcuppen@…

Yes, this email will not be added to trac (or at least in version-1.1.0)
due trough its subject containing a slash.


email2trac schreef:

comment:3 Changed 11 years ago by jcuppen@…


#196: The usage of a slash ( / ) in subjects is not permitted when forwarding.eml

Yes, this email will not be added to trac (or at least in version-1.1.0)
due trough its subject containing a slash.


email2trac schreef:
forwarding
------------------------------------+---------------------------------------
------------------------------------+---------------------------------------

Changed 11 years ago by jcuppen@…

Added by email2trac

comment:4 Changed 11 years ago by jcuppen@…


Undelivered Mail Returned to Sender.eml

This is the mail system at host subtrac2.rc.sara.nl.

I'm sorry to have to inform you that your message could not
be delivered to one or more recipients. It's attached below.

For further assistance, please send mail to postmaster.

If you do so, please include this problem report. You can
delete your own text from the attached returned message.

                   The mail system

<email2trac@subtrac.sara.nl>: Command died with status 1:
    "/usr/bin/run_email2trac --project email2trac". Command output: TD: saving
    email to /tmp/tmpaLl_GX.email2trac TD: writing body to
    /tmp/tmpGaQUb1.email2trac TD: part1: Content-Type: message/rfc822 TD:
    part1: filename: #196: The usage of a slash ( / ) in subjects is not
    permitted when forwarding.eml TD: writing part1 (/tmp/#196: The usage of a
    slash ( / ) in subjects is not permitted when forwarding.eml) Traceback
    (most recent call last):   File "/usr/bin/email2trac", line 1802, in
    <module>     tktparser.save_email_for_debug(m, True)   File
    "/usr/bin/email2trac", line 557, in save_email_for_debug
    self.debug_attachments(message_parts)   File "/usr/bin/email2trac", line
    516, in debug_attachments     fx = open(part_file, 'wb') IOError: [Errno 2]
    No such file or directory: '/tmp/#196: The usage of a slash ( / ) in
    subjects is not permitted when forwarding.eml'

None



None-1


#196: The usage of a slash ( / ) in subjects is not permitted when forwarding.eml

Yes, this email will not be added to trac (or at least in version-1.1.0)
due trough its subject containing a slash.


email2trac schreef:
forwarding
------------------------------------+---------------------------------------
------------------------------------+---------------------------------------

comment:5 Changed 11 years ago by jcuppen@…

As you can see, the problem only occur when forwarding. (the filename of the eml.)

    No such file or directory: '/tmp/#196: The usage of a slash ( / ) in
    subjects is not permitted when forwarding.eml'

comment:6 Changed 11 years ago by bas

Is is not the '/' in the subjact, But the forward is handled as attachment and there is the error.

comment:7 Changed 11 years ago by bas

Which trac version do you use?

comment:12 Changed 11 years ago by jcuppen@…

email2trac schreef:
We use:
||Trac          ||0.12multirepos-r9081||
||Python        ||2.5.2 (r252:60911, Jan 24 2010, 18:02:01) [GCC 4.3.2]||
||setuptools || 0.6c8||
||pytz ||       2009u||
||MySQL         ||server: "5.0.51a-24+lenny2", client: "5.0.51a", thread-safe: 1||
||MySQLdb       ||1.2.2||
||Genshi        ||0.6dev-r1092||
||Babel         ||0.9.4||
||mod_wsgi      ||2.5 (WSGIProcessGroup WSGIApplicationGroup %{GLOBAL})||
||Pygments      ||1.2.2||
||GIT   ||1.5.6.5||
||RPC   ||1.0.6||
||jQuery:       ||1.3.2||

comment:13 follow-up: Changed 11 years ago by bas

Ok i have re-enabled some code that normalized the filenames for attachments. Can you test it?

comment:14 in reply to: ↑ 13 Changed 11 years ago by jcuppen@…

  • Owner changed from bas to anonymous
  • Status changed from assigned to new

Replying to bas:

Ok i have re-enabled some code that normalized the filenames for attachments. Can you test it?

After modification i still receive the message:

    create_unique_file OSError: [Errno 2] No such file or directory:
    '/tmp/Email2trac test voor bugfix bij forward met een / in de
    header.eml' TD: saving email to /tmp/tmp5FX6Dz.email2trac

comment:11 Changed 11 years ago by bas

(In [348]) email2trac.py.in:

  • added some code that will replace the / and \ chars for attachments filenames with _. These chars are forbidden for Unix/Windows? environments. Alse when something goes wrong with an attachment. The error is displayed in the changelog of the ticket, see #196

comment:12 Changed 11 years ago by bas

  • Owner changed from anonymous to bas
  • Status changed from new to assigned

comment:13 follow-up: Changed 11 years ago by bas

Did you have a chance to test the new version r348.

comment:22 Changed 11 years ago by jcuppen@…

email2trac schreef:

Seems to be working, many thanks!!

ps we had to replace the first line:
{{{
-#!@PYTHON@
+#!/usr/bin/python
}}}

comment:23 Changed 11 years ago by bas

That is good to know. The last remark is strange. ./configure replace this string the path where python is installed.

comment:24 Changed 11 years ago by bas

  • Milestone set to 1.4.0
  • Resolution set to fixed
  • Status changed from assigned to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed The owner will remain bas.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.