Modify

Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#216 closed enhancement (fixed)

disallow multiple assignment of the same inline property

Reported by: Konstantin Ryabitsev <icon@…> Owned by: bas
Priority: major Milestone: release 2.0.0
Component: email2trac Version: 1.6.0
Keywords: Cc:

Description

(contd from #214)

Attached patch will only allow one assignment of the same inline property -- the first one. For example, take the following email using "outlook-style" quoting and top-posting:

I fixed your problem.

@status: closed
@resolution: fixed

----
From: Client
To: Developer
Sent: ...
Subject: Re: Please fix my problem

I will be fixing your problem shortly.

@status: accepted

Without the patch, the status will be set to "accepted" even though it's not the developer's intent. With this patch, the top-most assignment wins, and all further assignments are ignored.

Attachments (1)

inline-properties-first-come-first-served.patch (469 bytes) - added by Konstantin Ryabitsev <icon@…> 10 years ago.
Proposed patch

Download all attachments as: .zip

Change History (6)

Changed 10 years ago by Konstantin Ryabitsev <icon@…>

Proposed patch

comment:1 Changed 10 years ago by bas

  • Status changed from new to assigned
  • Type changed from enhancement to defect

Thanks for the patch. In your situation it is exactly what you want, but i have my mailer configured to start at the bottom of message. So it will not have the desired effect for me. email2trac will remove those lines it will never be included in a ticket or in a notification email. I know you have another kind of setup but as told mabye use a filter before the mail is send out.

comment:2 Changed 10 years ago by bas

  • Type changed from defect to enhancement

comment:3 Changed 10 years ago by Konstantin Ryabitsev <icon@…>

It shouldn't be a problem for any other case, because "traditional quoting" will use ">" to quote the message and all previous inline properties will not be parsed by email2trac.

The regex to parse inline properties is: \s*[@]\s*([a-zA-Z]+)\s*:(.*)$

In your case the email will look like this:

On ... Developer said:
> I will be fixing your problem shortly.
>
> @status: accepted

I fixed your problem.

@status: closed
@resolution: fixed

comment:4 Changed 10 years ago by bas

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [509]) added a new parameter: inline_properties_first_wins, closes #216

comment:5 Changed 10 years ago by bas

  • Milestone set to release 2.0.0

Add Comment

Modify Ticket

Change Properties
Action
as closed The owner will remain bas.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.