Modify

Opened 11 years ago

Closed 11 years ago

#218 closed defect (fixed)

Problem when multiple trac accounts match email address

Reported by: Konstantin Ryabitsev <icon@…> Owned by: bas
Priority: major Milestone: release 2.0.0
Component: email2trac Version: trunk
Keywords: Cc:

Description

I came across a problem when enabling "ticket_permission_system: trac". If there is more than one account that matches the same email address (e.g. for me it was both "konstantin" and "tracadmin" accounts), then the user lookup fails and email2trac treats emails from me as coming from a non-trac user. This tweak fixes the problem.

  • (a) email2trac.py.in vs. (b) -

    a b  
    339339                users = [ (u,n,e) for (u, n, e) in self.env.get_known_users(self.db)
    340340                        if e and (e.lower() == self.email_addr.lower()) ]
    341341
    342                 if len(users) == 1:
     342                if len(users) >= 1:
    343343                        self.email_from = users[0][0]
    344344                        self.author = users[0][0]
    345345

Attachments (0)

Change History (5)

comment:1 Changed 11 years ago by bas

  • Status changed from new to assigned
  • Version changed from 1.6.0 to trunk

Thanks wel be applied to trunk

comment:2 Changed 11 years ago by bas

(In [481]) applied patch from Konstantin Ryabitsev that solve that one email address can have multiple trac accounts, see #218

comment:3 Changed 11 years ago by Konstantin Ryabitsev <icon@…>

NB: I think you meant to use ">=" not "=>".

comment:4 Changed 11 years ago by bas

your right ;-)

comment:5 Changed 11 years ago by bas

  • Milestone set to release 1.7.0
  • Resolution set to fixed
  • Status changed from assigned to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed The owner will remain bas.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.