Modify

Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#227 closed enhancement (fixed)

[patch] allow '_' in inline properties

Reported by: thomas.moschny@… Owned by: bas
Priority: major Milestone:
Component: email2trac Version: 1.6.0
Keywords: Cc:

Description

The subject already says it. Is there a reason to not allow some more characters, especially '_' for the name of inline properties? We have custom fields which contain them, and I want people to be able to set these fields via mail.

Attachments (0)

Change History (4)

comment:1 Changed 12 years ago by thomas.moschny@…

  • Summary changed from Allow '_' in inline properties to [patch] allow '_' in inline properties

Here's a patch:

  • email2trac.py.in

     
    16971697                properties = dict()
    16981698                body = list()
    16991699
    1700                 INLINE_EXP = re.compile('\s*[@]\s*([a-zA-Z]+)\s*:(.*)$')
     1700                INLINE_EXP = re.compile('\s*[@]\s*(\w+)\s*:(.*)$')
    17011701
    17021702                for line in text.splitlines():
    17031703                        match = INLINE_EXP.match(line)

comment:2 Changed 12 years ago by bas

  • Status changed from new to assigned

First thanks for the patch. So it still has to start with '@' and after that we can have ticket fields that are considered as a word.

  • @customer_report: vu

Before this patch it was not allowed?

comment:3 Changed 12 years ago by bas

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [492]) allow more ticket fields to be updated by inline properties, closes #227

comment:4 Changed 12 years ago by thomas.moschny@…

Thanks for applying the patch!

Add Comment

Modify Ticket

Change Properties
Action
as closed The owner will remain bas.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.