HTML-parts are attached as `None` instead of `untiteled-part.ext`

[hju@…]

Since upgrade to email2trac 1.2.0 and trac 0.11.6 in 03/2010 (currently running email2trac 1.4.6), inline-parts of html-mails (like images/jpg or text/html) are attached as None. Anyway, images are included and shown "inline" in the Ticket-description as expected.

Obviously, part.get_filename() in def get_message_parts() returns 'None' instead of ''. So the code:

  if not filename:
    filename = 'untitled-part'

    # Guess the extension from the content type, use non strict mode
    # some additional non-standard but commonly used MIME types 
    # are also recognized
    #
    ext = mimetypes.guess_extension(part.get_content_type(), False)
    if not ext:
      ext = '.bin'

    filename = '%s%s' % (filename, ext)

in def unique_attachment_names() has no longer effekt at all.

As I couldn't find get_filename(), I can't trace down to the source of the problem. Is it email2trac or perhaps an issue of our trac-update?

Sorry for reporting so late, but I have not investigatet this any further...

[bas]

Thanks for the rpeort. I will try yo fix it

[bas]

(In [495]) Attachments without a name will be saved a 'untitled-part'. This used to be so, closes #230