Modify

Opened 10 years ago

Closed 10 years ago

#231 closed enhancement (fixed)

Sending new email2trac ticket via email because of spam rejection by Sara's Trac project

Reported by: dmcr@… Owned by: bas
Priority: major Milestone: release 2.0.0
Component: email2trac Version: 1.6.0
Keywords: Cc: basv@…

Description

Hi Bas,

I tried to submit the text below, and got the infamous ' Submission rejected
as potential spam' error. Don't know of any workaround except to email you
directly.

Here is a patch that fixes some problems with the discussion plugin support
code.

1) syntax error: 'logger' spelled as 'loggger'.
2) Trac 0.12.1 requires a locale to be specified in the Request object.
3) Could not test for whether the discussion plugin was enabled with
'tracdiscussion.api.*'. Had to use the full name of the parameter:
'tracdiscussion.api.discussionapi'.

Note: this raises the possibility that the analogous test for whether the
FullBlogPlugin is enabled might have the same problem. The code tests for
'tracfullblog.*'.

4) When the log_level parameter is set to debug, internally set the debug
parameter to get the full debug output. (Don't know if you agree with this
one, but it seemed useful to me.)

Let me know if you have any questions or problems with this patch. It is
generated against the latest svn release as of today: r494.

Dennis

email2trac-r494.patch

Attachments (1)

email2trac-r494.patch (1.5 KB) - added by dmcr@… 10 years ago.
Added by email2trac

Download all attachments as: .zip

Change History (5)

Changed 10 years ago by dmcr@…

Added by email2trac

comment:1 Changed 10 years ago by bas

  • Milestone set to release 1.7.0
  • Status changed from new to assigned
  • Type changed from defect to enhancement

Thanks for the patch!. You tested it with trac version 0,12. So are these changes 0.12 specific or can this also be applied for trac 0.11 version?

comment:3 Changed 10 years ago by dmcr@…

Hi,

I had to submit this via email again, as my reply was again rejected as
spam!
-------------------------------------------------------

Well, the only corrections that might be Trac-version-sensitive are 2 and 3.

Number 2 adds the 'locale' key to a hash. So if Trac 0.11 doesn't use this,
it can't hurt if it does not access it. The only way this could hurt is if
Trac 0.11 did not require this key, but used it if present; and then it
would only be a problem if 'None' was not an appropriate value (which it
obviously is in 0.12). It seems unlikely to me, if 0.11 used the 'locale'
key but did not require it (more code), that 0.12.1 would require it (less
code). It also seems unlikely to me that 'None' would not be a legitimate
value. But I don't suppose we can be completely sure without testing or
checking with a Trac developer (Christian Boos?). Perhaps the safest would
be to change my code to add the 'locale' key only in 0.12 (hopefully this is
not a requirement they added in 0.12.1).

Number 3: again it seems unlikely that if an '*' in a parameter name doesn't
work in 0.12.1 that it would work in 0.11. But even if it were so,
specifying the full name should be acceptable in either version. So I think
this one is safe.

Dennis

comment:4 Changed 10 years ago by bas

If you fill in an email address or username as reporter then it is accepted. Anonymous user input is considered as spam. I will apply the patches thanks for the info

comment:4 Changed 10 years ago by bas

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [496]) applied patch that fixes some dicussion plugin problems, closes #231

Add Comment

Modify Ticket

Change Properties
Action
as closed The owner will remain bas.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.