Modify

Opened 10 years ago

Closed 10 years ago

#290 closed enhancement (fixed)

the multiple white_list options should be inclusive not exclusive

Reported by: randy@… Owned by: bas
Priority: major Milestone:
Component: email2trac Version: 2.5.0
Keywords: Cc:

Description

white_list: ... white_list_registered_users: 1 white_list_file: ...

seem to be exclusive, while i expected them to be inclusive, i.e. an incoming matching any of them is allowed.

Attachments (0)

Change History (11)

comment:1 Changed 10 years ago by bas

  • Status changed from new to assigned

Randy,

The options are exclusive. You can set set white_List and white_list_file. These settings will be combined when into one variable that is checked.

If a user is registered user and white_list_registered_users is set set the mail will be accepted.

regards

comment:2 Changed 10 years ago by randy@…

i had

    white_list: randy@iij.ad.jp
    white_list_registered_users: 1
    #white_list_file:

and there is a registered user randy with email randy@psg.com

i sent email from randy@psg.com and it went into a black hole.  i
changed it to

    #white_list: randy@iij.ad.jp
    white_list_registered_users: 1
    #white_list_file:

and it worked

randy

comment:3 Changed 10 years ago by bas

Strange, there n must be a message in a log file that the message is rejected:

  • "'Message rejected : %s not in white list'"

I have done some test and can enable both options can you run the setup in debug mode and sent the output to me?

PS) I made some improvements to trunk so we have some log message for the new settings.

comment:4 Changed 10 years ago by randy@…


it seems logging should be enabled to syslog by default, but i am not
seeing anything

randy

comment:5 Changed 10 years ago by bas

You can set the debug to 1 in email2trac.conf and the raw email message will be saved in /tmp. On the command line:

  • email2trac -n -d < saved_filename

Really strange that you don't have any logging.

comment:6 Changed 10 years ago by randy@…

work0.psg.com:/tmp# email2trac -n -d < tmpE2aB_0.rgnet.email2trac
2012-02-22 09:44:43,692 email2trac rgnet: Found trac version: 0.12
2012-02-22 09:44:43,966 email2trac rgnet: Loading environment
/usr/local/www/share/wiki/rgnet
2012-02-22 09:44:44,335 email2trac rgnet: Main function parse
2012-02-22 09:44:44,335 email2trac rgnet: DRY_RUN: NOT saving email message
2012-02-22 09:44:44,339 email2trac rgnet: function get_sender_info
2012-02-22 09:44:44,340 email2trac rgnet: function email_to_unicode
2012-02-22 09:44:44,343 email2trac rgnet:        email name: Randy Bush,
email address: randy@psg.com
2012-02-22 09:44:44,345 email2trac rgnet: function email_header_acl:
white_list
2012-02-22 09:44:44,345 email2trac rgnet: Message rejected : randy@psg.com
not in white list

white_list: randy@iij.ad.jp
white_list_registered_users: 1
#white_list_file:

if i comment out white_list: it finds the registered user randy@psg.com


what is the logging process name?

randy

comment:7 Changed 10 years ago by bas

the logging process name is:

  • email2trac

Ah Randy which version did you install. The new options are only implemented in the trunk version. I did not release a 2.5.0 version!

If you comment out white_list all users are allowed!

comment:8 Changed 10 years ago by randy@…



i am downloading.  i do not know where to fetch cvs/svn.  and do not say
git to me, i am not a penguinista.


given that i might have other white_list_foo stuff that makes not too
much sense.

i think of it more as

white_list: randy, /usr/local/whitelist, REGISTERED, george, mary

iff it meets any of those conditions it passes.

randy

comment:9 Changed 10 years ago by bas

Randy,

I just released a new version. Just download this version and everything should work.

regards

comment:10 Changed 10 years ago by randy@…

ok, it seems to work!  thanks.

randy

comment:11 Changed 10 years ago by bas

  • Resolution set to fixed
  • Status changed from assigned to closed
  • Version changed from 2.4.7 to 2.5.0

your welcome. Thanks for testing this new feature. Will close this ticket

Add Comment

Modify Ticket

Change Properties
Action
as closed The owner will remain bas.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.