Opened 12 years ago
Closed 11 years ago
#295 closed enhancement (fixed)
Patch to get email2trac to work correctly with the Agilo plugin
Reported by: | anonymous | Owned by: | bas |
---|---|---|---|
Priority: | minor | Milestone: | |
Component: | email2trac | Version: | |
Keywords: | agilo | Cc: |
Description (last modified by bas)
The Agilo plugin breaks email2trac because it redefines Ticket. The following patch is a quick hack to get it working again.
--- email2trac.orig 2012-05-04 17:31:44.959978983 -0400 +++ email2trac 2012-05-04 17:32:03.960302778 -0400 @@ -1187,6 +1187,10 @@ self.logger.debug('function new_ticket') tkt = Ticket(self.env) + from agilo.utils.config import AgiloConfig + from agilo.ticket.model import AgiloTicket + if AgiloConfig(self.env).is_agilo_enabled: + tkt = AgiloTicket(self.env) self.set_reply_fields(tkt, msg)
Attachments (0)
Change History (8)
comment:1 Changed 12 years ago by bas
- Status changed from new to assigned
comment:2 Changed 12 years ago by bas
I read on the website:
Core modules that need to be disabled Please make sure that you still retain the disabled state of these core Trac plugins, or Agilo will not work correctly: trac.ticket.api.ticketsystem = disabled trac.ticket.roadmap.roadmapmodule = disabled trac.ticket.web_ui.ticketmodule = disabled
comment:3 Changed 12 years ago by anonymous
Yes, those three Trac systems need to be disabled in order to use Agilo. They then use AgiloTicket? everywhere instead of Ticket, and it breaks a number of plugins. I don't know if there is a clean way to handle this in email2trac, but I'm hoping the above patch at least helps out anyone else who has run into this problem.
comment:4 follow-up: ↓ 5 Changed 12 years ago by bas
Thanks you only have patched it for new tickets. Must this also be applied for ticket_updates?
comment:5 in reply to: ↑ 4 ; follow-up: ↓ 6 Changed 12 years ago by bas
- Version 2.5.0 deleted
Replying to bas:
Thanks you only have patched it for new tickets. Must this also be applied for ticket_updated?
Yes or NNo ;-)
comment:6 in reply to: ↑ 5 Changed 11 years ago by smcclure@…
Replying to bas:
Replying to bas:
Thanks you only have patched it for new tickets. Must this also be applied for ticket_updated?
Yes or No? ;-)
Yes. I used this:
982,987d981 < # Agilo specific modifications < from agilo.utils.config import AgiloConfig < if AgiloConfig(self.env).is_agilo_enabled: < from agilo.ticket.model import AgiloTicket < tkt = AgiloTicket(self.env, self.id, self.db) < 1217,1222d1210 < # Agilo specific modifications < from agilo.utils.config import AgiloConfig < if AgiloConfig(self.env).is_agilo_enabled: < from agilo.ticket.model import AgiloTicket < tkt = AgiloTicket(self.env) <
comment:7 Changed 11 years ago by bas
- Description modified (diff)
I forgot to close this. Agilo support is in version 2.7.0 and higher
comment:8 Changed 11 years ago by bas
- Resolution set to fixed
- Status changed from assigned to closed
Thanks for the patch.
Does the agilo plugin require you to modify the trac.ini or it just redefines the Ticket() function?