Modify

Opened 13 years ago

Closed 13 years ago

Last modified 12 years ago

#33 closed defect (duplicate)

Using long name for post

Reported by: anonymous Owned by: bas
Priority: major Milestone:
Component: email2trac Version: 0.1
Keywords: Cc:

Description

I have tom@… and scott@… that are involved with a ticket. When "Scott Serr <scott@…>" uses email2trac to reply to this ticket, it shows in Trac as being changed by "Scott Serr" and not "scott" which is his short name (user name) in trac. This is not bad, but now the email notifications are not going to just tom and scott, they also go to "Serr@…" also... which doesn't exist.

I'm looking at get_author_emailaddrs() at about line 334-353 in the latest release of email2trac.

        # Look for email address in registered trac users
        #
        users = [ u for (u, n, e) in self.env.get_known_users(self.db)
                         if e == self.email_addr ]

        if len(users) == 1:
             self.email_from = users[0]
        else:
             self.email_from =  self.email_to_unicode(message['from'])
             #self.email_from =  self.email_to_unicode(self.email_addr)

Yes, "scott" has filled out his Trac settings name "Scott Serr" and email "scott@…". I'm not a Python programmer, but it seems the users variable is not filled with the right stuff. Help?

Attachments (0)

Change History (5)

comment:1 Changed 13 years ago by bas

  • Status changed from new to assigned

i am now at the LISA conference. when i am back i wll will look into it. Thanks for the report. It could also be that this is trac bug. When you submit a ticket via the web interface you do get a notification?

comment:2 follow-up: Changed 13 years ago by anonymous

I suspected that I wouldn't, but I did!

One to scott@… (which is stored in trac... and the sender's From: address) And another one to Serr@… which of course can't get delivered.

I'm using Trac 0.10.4. Thanks, -Scott (wish I was at LISA)

comment:3 in reply to: ↑ 2 Changed 13 years ago by anonymous

Replying to anonymous:

I suspected that I wouldn't, but I did!

that should have been "but it did!"

comment:4 Changed 13 years ago by bas

  • Resolution set to duplicate
  • Status changed from assigned to closed

see ticket #41 for explanation, i will add this to a FAQ section, he must fill in his short name in the settings file, maybe i will create an option to skip settings setting.

comment:5 Changed 13 years ago by anonymous

This is fixed in the new release of email2trac

Add Comment

Modify Ticket

Change Properties
Action
as closed The owner will remain bas.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.