Modify

Opened 6 years ago

Closed 6 years ago

#341 closed enhancement (fixed)

format-security problem

Reported by: thomas.moschny@… Owned by: bas
Priority: major Milestone:
Component: email2trac Version:
Keywords: Cc:

Description

When run_email2trac.c is compiled with -Werror=format-security, this error is thrown:

gcc -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches  -m64 -mtune=generic -o run_email2trac run_email2trac.c
run_email2trac.c: In function 'email2trac_log':
run_email2trac.c:59:5: error: format not a string literal and no format arguments [-Werror=format-security]
     syslog(LOG_ERR, message);
     ^

The attached patch fixes this.

Attachments (1)

email2trac-2.8.0-format-security.patch (488 bytes) - added by thomas.moschny@… 6 years ago.

Download all attachments as: .zip

Change History (3)

Changed 6 years ago by thomas.moschny@…

comment:1 Changed 6 years ago by bas

  • Status changed from new to assigned
  • Type changed from defect to enhancement

Thanks for the patch and catching this error. I will apply it and release an new version.

comment:2 Changed 6 years ago by bas

  • Resolution set to fixed
  • Status changed from assigned to closed

In 654:

fixed format-security problem, closes #341
fixed Typo in variable assignment, closes #342

Add Comment

Modify Ticket

Change Properties
Action
as closed The owner will remain bas.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.