Modify

Opened 13 years ago

Closed 13 years ago

#36 closed enhancement (fixed)

read the configuration file with trac Configuration class

Reported by: andrei2102@… Owned by: bas
Priority: major Milestone:
Component: email2trac Version: 0.13
Keywords: Cc:

Description

I'm implementing email2trac for a trac installation and I integrated the configuration file of the email2trac with the one of the trac it self. Using the trac configuration reader makes more sense to me and it can be united with all other configurations.

The ticket has a diff attached with the modifications. It works for trac 0.11. I didn't tested for older versions.

Attachments (6)

trac.0.11.diff (759 bytes) - added by andrei2102@… 13 years ago.
diff with the changes
trac-config.diff (1.1 KB) - added by andrei2102@… 13 years ago.
patch after changeset [193]
part0001.html (271 bytes) - added by Culapov Andrei 13 years ago.
Added by email2trac
email2trac.0.13.diff (1.1 KB) - added by andrei2102@… 13 years ago.
patch against the latest release
part0001.2.html (2.0 KB) - added by Culapov Andrei 13 years ago.
Added by email2trac
part0001.3.html (203 bytes) - added by Culapov Andrei 13 years ago.
Added by email2trac

Download all attachments as: .zip

Change History (22)

Changed 13 years ago by andrei2102@…

diff with the changes

comment:1 Changed 13 years ago by bas

  • Status changed from new to assigned

andrei,

Thanks is a good suggestion, can you send the diff version with a option -u. So i can apply the diff/patch on the source ;-)

I use email2trac for several projects. So in my email2trac.conf there are multiple trac projects listed. Is you patch per project (trac.ini) or can this also be in a global trac.ini file?

comment:2 Changed 13 years ago by anonymous

Using the Configuration class from trac.config will not change the way in which email2trac works now.

It just allows to:

  • keep for a project all configurations in a single file;
  • have defaults values in a inherited configuration file, so I can set an option default value for all trac environments;
  • integrate email2trac as a trac plugin.

I'll upload a patch after I'll test the trunk code changed after [192] (ticket #35).

Changed 13 years ago by andrei2102@…

patch after changeset [193]

comment:3 Changed 13 years ago by andrei2102@…

I see that you made a new release and I'll test it today. About this ticket can I offer you any more details, any other information?

comment:4 Changed 13 years ago by bas

I had just a lot of small changes and bug fixes. So that is why i released a new version. Before i decide to incorporate this patch i want to test it and see if it gives some benefits above my own configuration file. But can you resend your patch against the last trunk version. Just for the info i mean a diff-u patch.

Thanks

Changed 13 years ago by Culapov Andrei

Added by email2trac

comment:5 Changed 13 years ago by Culapov Andrei

Ok, I'll make a patch against the latest release and add it to the
ticket.
The biggest benefit, in general, is that you can keep all the
configurations
in a single file and also you can manage the email2trac settings from
a web
page in the trac admin panel.

comment:6 Changed 13 years ago by bas

I did not now that we can set the email2trac configuration with the trac admin panel. That is a big advantage ;-)

Thanks

comment:7 Changed 13 years ago by Culapov Andrei

yes we have all the settings in the trac.ini file and made a plugin to
handle the settings. A web interface is very handy.

Changed 13 years ago by andrei2102@…

patch against the latest release

comment:8 Changed 13 years ago by andrei2102@…

I tested the new release and it's good. I added the patch also.

comment:9 Changed 13 years ago by bas

Thanks for the patch. I will apply and test it

comment:10 Changed 13 years ago by rcorsaro@…

What's happening with this patch? I'd love to see it committed.

comment:11 Changed 13 years ago by bas

  • Version changed from 0.1 to 0.13

I have added the patch and asked the author for some comments. Because i can not set the parameters in trac,ini as suggested and i also get some errors in combo with mod_python.

You can also test it and apply the patch that is attached to this ticket

Changed 13 years ago by Culapov Andrei

Added by email2trac

comment:12 Changed 13 years ago by Culapov Andrei

what errors do you encountered? can you add them to the ticket for me
to try
to solve them?

On Mon, Mar 24, 2008 at 9:20 PM, email2trac <email2trac@sara.nl>
wrote:

> #36: read the configuration file with trac Configuration class
>
> ---------------------------------+----------------------------------
--------
> Reporter:  andrei2102@gmail.com  |        Owner:  bas
>     Type:  enhancement           |       Status:  assigned
> Priority:  major                 |    Component:  email2trac
>  Version:  0.13                  |   Resolution:
> Keywords:                        |
>
> ---------------------------------+----------------------------------
--------
> Changes (by bas):
>
>  * version:  0.10 => 0.13
>
> Comment:
>
>  I have added the patch and asked the author for some comments.
Because i
>  can not set the parameters in trac,ini as suggested and i also get
some
>  errors in combo with mod_python.
>
>  You can also test it and apply the patch that is attached to this
ticket
>
> --
> Ticket URL:
<https://subtrac.sara.nl/oss/email2trac/ticket/36#comment:11>
> email2trac <https://subtrac.sara.nl/oss/email2trac>
> Documentation server for email2trac
>

comment:13 Changed 13 years ago by anonymous

andrei,

My question is to which section i must add the configuration parameters of email2trac in the trac.ini, I have also installed the TracWebAdmin? plugin. My question is what i have to do to set the config parameters with this plugin.

As for now it reads the /etc/email2trac,conf file and do not see the benefits.

Changed 13 years ago by Culapov Andrei

Added by email2trac

comment:14 Changed 13 years ago by Culapov Andrei

I created a trac plugin that has all the email2trac parameters as
options.
The configurations I've putted under the email2trac section. For
editing the
configurations i use the IniAdmin plugin.

comment:15 Changed 13 years ago by anonymous

Thanks for the info, Can you send me the trac-plugin or an example?

comment:16 Changed 13 years ago by bas

  • Resolution set to fixed
  • Status changed from assigned to closed

I have applied the patch to the trunk version

Add Comment

Modify Ticket

Change Properties
Action
as closed The owner will remain bas.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.