Modify

Opened 6 years ago

Closed 6 years ago

#364 closed enhancement (fixed)

notify_sender doesn't work, probably since r633

Reported by: kroseneg@… Owned by: bas
Priority: major Milestone:
Component: email2trac Version: 2.8.4
Keywords: Cc:

Description

Error message:

Failure sending notification on creation of ticket #22212: global name 'sender_email' is not defined

sender_email was used globally for self.email_addr, now tn.email2trac_notify_reporter is used.

This patch fixes the problem:

--- email2trac.py.in	(revision 660)
+++ email2trac.py.in	(working copy)
@@ -2486,7 +2486,7 @@
 
                 if self.email2trac_notify_reporter:
                     if not self.email2trac_notify_reporter in torcpts:
-                        torcpts.append(sender_email)
+                        torcpts.append(self.email2trac_notify_reporter)
 
                 if self.email2trac_replyto:
                     # use to rewrite reply to

Attachments (0)

Change History (4)

comment:1 Changed 6 years ago by bas

  • Status changed from new to assigned
  • Type changed from defect to enhancement

Thanks for the patch. I will apply it

comment:2 Changed 6 years ago by bas

  • Resolution set to fixed
  • Status changed from assigned to closed

In 661:

applied the patch, close #364

comment:3 Changed 6 years ago by kroseneg@…

  • Resolution fixed deleted
  • Status changed from closed to reopened

Thanks for applying the patch, unfortunately you missed the "s" in "self".

comment:4 Changed 6 years ago by bas

  • Resolution set to fixed
  • Status changed from reopened to closed

In 664:

Did not apply the patch correctly ;-(, close #364

Add Comment

Modify Ticket

Change Properties
Action
as closed The owner will remain bas.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.