Strip email quotes

[trac@…]

Is is possible to have email2trac automatically strip quotes from the email when updating? this will allow users to append a new comment to the ticket by pressing the reply (without cleaning the email body first).

[bas]

That feature will be a nice feature. If we add if we must make it configurable option.

[anonymous]

I've made a patch for that feature. Feel free to add it to main branch.

config options:

strip_quotes: <int> (default: 0) mail_quote: <quote chars> (default: "> ")

diff -u /usr/local/src/email2trac-0.10/debian/email2trac/usr/bin/email2trac /usr/bin/email2trac 
--- /usr/local/src/email2trac-0.10/debian/email2trac/usr/bin/email2trac 2007-08-13 00:21:12.000000000 +0000
+++ /usr/bin/email2trac 2007-10-05 20:45:38.000000000 +0000
@@ -164,6 +164,11 @@
                if parameters.has_key('email_comment'):
                        self.comment = str(parameters['email_comment'])
 
+               if parameters.has_key('email_quote'):
+                       self.quote = str(parameters['email_quote'])
+                else:
+                        self.quote = '> '
+                
                if parameters.has_key('email_header'):
                        self.EMAIL_HEADER = int(parameters['email_header'])
                else:
@@ -199,6 +204,11 @@
                else:
                        self.STRIP_SIGNATURE = 0
 
+               if parameters.has_key('strip_quotes'):
+                       self.STRIP_QUOTES = int(parameters['strip_quotes'])
+               else:
+                       self.STRIP_QUOTES = 0
+
                if parameters.has_key('use_textwrap'):
                        self.USE_TEXTWRAP = int(parameters['use_textwrap'])
                else:
@@ -677,6 +687,18 @@
 
                return ('\n'.join(body))
 
+       def strip_quotes(self, text):
+               """
+               Strip quotes from message by Nicolas Mendoza
+               """
+               body = []
+               for line in text.splitlines():
+                       if line.startswith(self.comment):
+                               continue
+                       body.append(line)
+
+               return ('\n'.join(body))
+
 
        def wrap_text(self, text, replace_whitespace = False):
                """
@@ -728,6 +750,9 @@
                                if self.STRIP_SIGNATURE:
                                        body_text = self.strip_signature(body_text)
 
+                               if self.STRIP_QUOTES:
+                                       body_text = self.strip_quotes(body_text)
+
                                if self.USE_TEXTWRAP:
                                        body_text = self.wrap_text(body_text)

[nicolasm@…]

Oh these came out wrong, and you can reach at the mail address I just used.

strip_quotes: <int> (default: 0)

mail_quote: <quote chars> (default: "> ")

[anonymous]

gah,

email_quote: <quote chars> (default: "> ")

[bas]

Thanks for the patch, I will add it to the trunk version. Now we must definethe quote character there is no way to determine the quote character automatically?

[anonymous]

There probably is some ways, you might want to check some RFCs for the default and add some extra heuristics for more exotic variations like: "^{NM> ", ">>* " etc.. maybe this: ​http://www.ietf.org/rfc/rfc2646.txt 4.5}

[bas]

Thanks for the info. If somebody wants to submit a update patch. I will appreciate it ;-)

[bas]

There is ane email_quote defined but you use email.comment in your patch. Must that also be:

line.startswith(self.comment): 

replaced by

line.startswith(self.quote:

[bas]

Added to trunk version

[nicolasm@…]

bas: you are right, sorry.

[anonymous]

This is fixed in new version. That will be released soon.