Modify

Opened 13 years ago

Closed 13 years ago

Last modified 13 years ago

#74 closed defect (fixed)

black_list always includes "MAILER-DAEMON@"

Reported by: email2trac@… Owned by: bas
Priority: major Milestone:
Component: email2trac Version: 0.3
Keywords: Cc:

Description

This may be a fringe usage, but we redirect certain bounce emails to email2trac so that we can keep track of them in Trac.

It was great that 0.30 introduced the black_list parameter. Unfortunately, even if the parameter is empty, "MAILER-DAEMON@" will always be added to it.

Is there a reason why this configuration parameter behaves as such? If it is to prevent email loops, perhaps email2trac can set a separate X-* header and check explicitly for that?

Attachments (0)

Change History (5)

comment:1 Changed 13 years ago by bas

  • Status changed from new to assigned

the MAILER-DEAMON@ was already and active before version 0.30. In version 0,30 we just made an option for it. For backwards compatibility we made MAILER-DAEMON@ a defautl value. Maybe it is better to remove this default setting and leave the users decide.

The X-header setting is not useful because most X-headers are removed from the mail if a user replies to trac mail.

comment:2 Changed 13 years ago by bas

  • Resolution set to fixed
  • Status changed from assigned to closed

Did not hear anything back

comment:3 Changed 13 years ago by email2trac@…

  • Resolution fixed deleted
  • Status changed from closed to reopened

Odd. I received an email for the 2nd comment, but not the 1st (not in my spam folder either).

I see now how the setting came to be so. Is backwards compatibility high on the priority, in particular for this setting? If so, perhaps the behavior can be:

  • if black_list is absent from the config file, use the default value
  • if black_list is present but has an empty value, use the empty value

This assumes that parsing the config file distinguishes between non-existent keys and null values.

comment:4 Changed 13 years ago by bas

  • Resolution set to fixed
  • Status changed from reopened to closed

Your right this fixed in the trunk version. black_list is now emapty and we do not add MAILER-DEAMON@ anymore.

You did not get a response for teh 1st one because notify_owner = False due to Spam attacks. That is now fixed ;-)

comment:5 Changed 13 years ago by anonymous

Awesome. Thanks!

Add Comment

Modify Ticket

Change Properties
Action
as closed The owner will remain bas.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.