Changeset 146 for trunk/daemon/togad.py

Timestamp:

06/20/05 09:08:38 (19 years ago)

Author:

bastiaans

Message:

daemon/togad.py:

• Fixed: rrdtool pipes were never closed, cuasing memory hogs and zombie processes

File:

• trunk/daemon/togad.py (modified) (3 diffs)

trunk/daemon/togad.py

@@ -317 +317 @@
                 debug_msg( 8, self.binary + ' ' + action + ' ' + filename + ' ' + arg_string  )
 
-                for line in os.popen( self.binary + ' ' + action + ' ' + filename + ' ' + arg_string ).readlines():
+                cmd = os.popen( self.binary + ' ' + action + ' ' + filename + ' ' + arg_string )
+                lines = cmd.readlines()
+                cmd.close()
+
+                for line in lines:
 
                         if line.find( 'ERROR' ) != -1:
@@ -1125 +1129 @@
                                 for period, pmetric in metric_serial_table.items():
 
-                                        self.createCheck( hostname, metricname, period )        
+                                        create_ret = self.createCheck( hostname, metricname, period )   
 
                                         update_ret = self.update( hostname, metricname, period, pmetric )
@@ -1135 +1139 @@
                                                 debug_msg( 9, 'metric update failed' )
 
+                                        update_rets.append( create_ret )
                                         update_rets.append( update_ret )