Modify ↓
Opened 11 years ago
Closed 10 years ago
#32 closed defect (fixed)
incorrect version check
Reported by: | thomas.moschny@… | Owned by: | bas |
---|---|---|---|
Priority: | major | Milestone: | |
Component: | pbs | Version: | 4.3.3 |
Keywords: | Cc: |
Description
While trying to use pbs_python with Torque 3.0.0 we saw that the 2.1 versions of pbs.py and pbs_wrap.py are symlinked and used, and not the 2.4 ones. This results in certain functions not being available.
The reason is this check in setup.py:
if major_version >= 2 and minor_version >= 4 and build_version >= 7:
Obviously this evals to False when major_version is 3, but minor_version and build_version are 0.
Using tuple comparison like this:
if (major_version, minor_version, build_version) > (2, 4, 7):
fixes the issue for us.
Attachments (0)
Change History (3)
comment:1 Changed 11 years ago by anonymous
comment:2 Changed 11 years ago by bas
Thanks for the patch. I will apply it. It is on my todo list to port pbs_pyhton to torque 4.X. But at our site we still run 2.4.X.
comment:3 Changed 10 years ago by bas
- Resolution set to fixed
- Status changed from new to closed
Versions check is completely rewritten thanks to Stijn de Weirdt.
Note: See
TracTickets for help on using
tickets.
Thinking about it, it should probably be