Modify

Opened 9 years ago

Last modified 6 years ago

#41 assigned enhancement

Make pbs_python work s.t. we can install using python setup.py install

Reported by: ewan.higgs@… Owned by: bas
Priority: major Milestone:
Component: pbs Version: 4.4.0
Keywords: build tox Cc:

Description

Some tools require that we can merely run python setup.py install. e.g. If pbs_python is a dependency for a project using tox. This improvement would also mean we no longer have to look at autotools generated code. :)

I already have a patch to do this:

https://github.ugent.be/ehiggs/pbs-python/commit/518b59e8f070f3d1d35dbf981b9cbbeafbeed033

Attachments (2)

build-using-setup.py.patch (98.3 KB) - added by ewan.higgs@… 9 years ago.
Patch in case the internal github is not accessible.
setup_no_autotools.py (3.2 KB) - added by anonymous 6 years ago.

Download all attachments as: .zip

Change History (12)

Changed 9 years ago by ewan.higgs@…

Patch in case the internal github is not accessible.

comment:1 follow-up: Changed 8 years ago by ewan.higgs@…

Any update on this?

comment:2 in reply to: ↑ 1 Changed 8 years ago by bas

Replying to ewan.higgs@…:

Any update on this?

We use this to detect how to compile the package for different oses and install it in different place. I won't remove the autotools setup. Maybe we can add a seperate setup.py that can be used by people that don't want the autotools setup.

comment:3 Changed 8 years ago by bas

I am just returning from Ghent. I attended http://cfgmgmtcamp.eu/. we could have meet ;-)

comment:4 follow-up: Changed 7 years ago by kenneth.hoste@…

Also supporting a setup.py based installation would make a lot of sense... +1

comment:5 in reply to: ↑ 4 Changed 7 years ago by bas

Replying to kenneth.hoste@…:

Also supporting a setup.py based installation would make a lot of sense... +1

Just give a seperate setup.py then i can include it. The patch will remove the old way of configuring the package

comment:6 follow-up: Changed 6 years ago by stijn.deweirdt@…

i attached a patch based on ewan's work from https://github.com/ehiggs/pbs-python/blob/master/setup.py

i hope it's acceptable

Changed 6 years ago by anonymous

comment:7 in reply to: ↑ 6 Changed 6 years ago by bas

  • Status changed from new to assigned

Replying to stijn.deweirdt@…:

i attached a patch based on ewan's work from https://github.com/ehiggs/pbs-python/blob/master/setup.py

i hope it's acceptable

Thanks for the patch. I will look at your patch. I am also in the progress of moving this to gitlab.

comment:8 Changed 6 years ago by bas

added another way to install pbs_python. Thanks to

  • stijn.deweirdt@… and ewan.higgs@…

sligtly modifiied, see #41

comment:9 Changed 6 years ago by jens.timmerman@…

hi, I noticed the file is now called setup_no_autotools.py so in fact, python setup.py install will still not work. This is what easy_install, pip etc call when trying to install a tarball, git repo or pypi release. so not naming the file setup.py sadly enought doesn't make these things work yet.1

comment:10 Changed 6 years ago by bas

This was just the first step to include it. As noticed the script has been changed and test in our environmnet, because it did not work. before making it default it must be well tested an known to work.

Then we could make this the default setup.py. And you could choose which one to use. The default one or run the configure script that generates a setup.py or setup_autrools.py.

Add Comment

Modify Ticket

Change Properties
Action
as assigned The owner will remain bas.
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from bas to the specified user. Next status will be 'new'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.