Custom Query (332 matches)

JPG images that are attached embed and visible upon clicking the
ticket.

Maybe if you had a skitch account it would send there as I know there
are some limitations in embedding your own images.

I got an error message from email2trac (urllib.quote):

Traceback (most recent call last):
  File "/usr/bin/email2trac", line 1574, in <module>#012    tktparser.parse(sys.stdin)
  File "/usr/bin/email2trac", line 991, in parse#012    self.new_ticket(m, subject, spam_msg)
  File "/usr/bin/email2trac", line 805, in new_ticket#012    message_parts = self.unique_attachment_names(message_parts)
  File "/usr/bin/email2trac", line 1231, in unique_attachment_names#012    filename = urllib.quote(filename)
  File "/usr/lib/python2.5/urllib.py", line 1205, in quote#012    res = map(safe_map.__getitem__, s)
KeyError: u'\xf3'

Result was, that the ticket could not be created. I patched email2trac. Now it works, but I'm not sure, whether the patch is the best solution:

--- /usr/bin/email2trac.orig    2009-06-04 13:34:33.000000000 +0200
+++ /usr/bin/email2trac 2009-06-04 15:36:29.000000000 +0200
@@ -1228,7 +1228,7 @@
                                        pass
 
                        if self.QUOTE_ATTACHMENT_FILENAMES:
-                               filename = urllib.quote(filename)
+                               filename = urllib.quote(filename.encode('utf-8'))
 
                        # Make the filename unique for this ticket
                        num = 0

Hi Bas,

We are now using a more secure approach to group ownership and file permissions that supports 1) webserver r/w access, 2) r/w access by selected users who are logged in via ssh, and 3) no other r/w access.

The idea is to create a supplementary group whose only members are the webserver user, and the selected ssh users. World access is then removed from all dual-access files (i.e., files writable via webserver and ssh). Thus, with a umask of 007 and the gid bit set, all created dual-access files are group-writable by users belonging to the special supplementary group, and to no one else.

Currently, besides the uid, run_email2trac sets only the gid associated with the trac user. This patch will cause it to also set the supplementary groups associated with the trac user, thus supporting a "best practices" approach to dual-access.

Let me know if you have any questions.

Dennis McRitchie?