#29 closed defect (fixed)
Detailed informations on an old job
Reported by: | alexis.michon@… | Owned by: | bastiaans |
---|---|---|---|
Priority: | normal | Milestone: | 0.3 |
Component: | web | Version: | 0.2 |
Keywords: | Cc: | ||
Estimated Number of Hours: | |||
Description
When i click on the graph at the bottom, i go to the joblist page instead of going to the details page for the time period of selected job.
All lines which speak of host in search.php are commented, that's normal? Uncomment these lines solves the problem.
Change History (9)
comment:1 Changed 17 years ago by bastiaans
- Cc alexis.michon@… added
- Owner changed from somebody to bastiaans
- Status changed from new to assigned
comment:2 Changed 17 years ago by bastiaans
- Cc alexis.michon@… removed
comment:3 Changed 17 years ago by anonymous
oups, it's not search.php, but index.php
--- index.php.orig 2007-04-19 12:38:45.000000000 +0200 +++ index.php 2007-05-07 10:08:31.000000000 +0200 @@ -26,6 +26,9 @@ extract( $_GET ); } +ini_set("memory_limit","20M"); +set_time_limit(0); + $my_dir = getcwd(); include_once "./libtoga.php"; @@ -387,7 +390,8 @@ if( isset( $h ) and $h != '' ) { $hostname = $h; - //$view = "host"; +# Alex + $view = "host"; } switch( $view ) { @@ -402,10 +406,10 @@ includeSearchPage(); break; - //case "host": + case "host": - // includeHostPage(); - // break; + includeHostPage(); + break; default: @@ -435,11 +439,11 @@ makeSearchPage(); break; - //case "host": + case "host": - // include "./host_view.php"; - // makeHostView(); - // break; + include "./host_view.php"; + makeHostView(); + break;
comment:4 Changed 17 years ago by a.michon@…
Hello, a small precision, the first three lines are when joblist lists +1000 jobs :
+ini_set("memory_limit","20M"); +set_time_limit(0); +
All remaining lines are linked to the problem
comment:5 Changed 17 years ago by bastiaans
- Cc a.michon@… added
Thanks again for the patch and contribution. Your correct on the memory limit, I never thought of setting it from the code. I'll check this out soon and incorporate it in the source asap too.
comment:6 Changed 17 years ago by bastiaans
- Cc a.michon@… removed
comment:7 Changed 17 years ago by bastiaans
- Cc a.michon@… added
- Milestone set to 0.2.1
- Resolution set to fixed
- Status changed from assigned to closed
I have changed your patch a little Alexis.
Can't always set the view to host whenever a hostname is set, or else the normal Joblist won't work anymore. Now the host view is set correctly from search.php.
See changeset r399.
https://subtrac.sara.nl/oss/jobmonarch/changeset/399
I have also removed the size restrictions on the graphs, so that the image text is better readable.
Thanks, cheers.
comment:8 Changed 17 years ago by bastiaans
- Cc a.michon@… removed
comment:9 Changed 16 years ago by anonymous
baidu 163 sina beiing hotel hotel 太阳能4 star hotel2 star hotel
5 star hotelwrought iron stair railings stair railings outdoor stair railings aluminum stair railing wrought iron stair baluster wrought iron stair railing parts staircase handrail iron stair rails interior metal staircase
Hm the behaviour you illustrate is indeed not correct, it should link to to appropriate Ganglia page for that host. It seems with the incorporation with the host filter for the joblist something was broken in the jobarchive.
Which lines are you talking about in search.php?