Opened 14 years ago

Closed 13 years ago

Last modified 13 years ago

#34 closed defect (fixed)

jobarchived threads dont exit correctly if datasource unavailable

Reported by: bastiaans Owned by: bastiaans
Priority: major Milestone: 0.3
Component: jobarchived Version: trunk
Keywords: Cc:
Estimated Number of Hours:

Description

and it keeps on firing off new parsing threads, causing a rapid memory usage increase.

appareantly the thread.join() doesn't kill off the threads correctly

Change History (4)

comment:1 Changed 14 years ago by bastiaans

  • Owner changed from somebody to bastiaans
  • Status changed from new to assigned

comment:2 Changed 13 years ago by bastiaans

  • Milestone set to 0.3
  • Priority changed from normal to major
  • Version changed from 0.2 to trunk

comment:3 Changed 13 years ago by bastiaans

  • Resolution set to fixed
  • Status changed from assigned to closed

thread.join() only waits for a thread to finish, it doesn't kill it.

threading model possibly needs to be reviewed, if RRD writes are slow the same thing might happen for storage threads. At least the major bug is fixed now, parseThread will return correctly now if the datasource is unavailable and will not keep on firing off new threads until out of memory.

See changeset r469 for the fix.

TODO: make sure storage threads can be stopped when they take too long to complete, see ticket #45

Note: See TracTickets for help on using tickets.