Modify

Opened 12 years ago

Closed 12 years ago

#142 closed defect (fixed)

Some fields are no longer available using alternate_notify_template

Reported by: hju@… Owned by: bas
Priority: major Milestone: 0.90
Component: email2trac Version: 0.80
Keywords: Cc:

Description

In our old environment (email2trac 0.30 / trunk 218) we are using the alternate_notify_template to inform the reporter about acceptance of the ticket.

In the mail-body we use the following text (example):

Hello,

your request was insertet as $ticket.id in our system.

Your request was:

$ticket.description

...

Everything works fine!

Now we have established a new environment under windows with email2trac 0.80 and python 2.5.

Problem: The $ticket.description is displayed, but $ticket.id is empty. In the Mail-Header, the ID ist displayed!

Taking a close look shows: with the "old" email2trac, if a ticket was created there was "change-entry" for each ticket:

*id  set to 411

this is now missing.

Is it possible, that the ID is no longer known due to this missing "update"?

Attachments (0)

Change History (9)

comment:1 Changed 12 years ago by bas

(In [273]) email2trac.py.in:

  • some trac functions are depend on ticket id, see #142

comment:2 Changed 12 years ago by bas

  • Status changed from new to assigned

can you test this version?

comment:3 Changed 12 years ago by hju@…

results will be posted after testing

comment:4 Changed 12 years ago by anonymous

Did you had time to test it?

comment:5 Changed 12 years ago by anonymous

Its in progress...

comment:6 Changed 12 years ago by hju@…

Including the codesnipped results in no notification at all.

Tried some modifications - noch changes. There is no notifikation at all.

I agree that this ist the significant change in the code. I don't get the point (yet) why it is not running...

comment:7 Changed 12 years ago by hju@…

more testing:

I mails are sent (was a problem in the Mail-Server) but the ID is not present.

Comparing the different code
The "old" code:

		if self.DRY_RUN:
			ticket_id = 'DRY_RUN'
		else:
			ticket_id = tkt.insert()
			
		tkt['id'] = ticket_id

		changed = False
		comment = ''

In version 0.8 the code looks different:

		if not self.DRY_RUN:
			self.id = tkt.insert()
		
		changed = False
		comment = ''

perhaps there is the clue? Look like the snipped has to look like this:

                if self.notify_template: 
                    tkt['id'] = SELF.ID  
                    changed = True 

A test with this code was succesful under 0.8 ...

comment:8 Changed 12 years ago by bas

  • Milestone set to 0.90

THanks for the info. I have applied it to the trunk version. Just back from vacation

comment:9 Changed 12 years ago by bas

  • Resolution set to fixed
  • Status changed from assigned to closed

applied to trunk see changeset [274]

Add Comment

Modify Ticket

Change Properties
Action
as closed The owner will remain bas.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.