Modify

Opened 14 years ago

Closed 14 years ago

Last modified 14 years ago

#179 closed enhancement (fixed)

Email with blank subject will fail

Reported by: xurizaemon Owned by: bas
Priority: major Milestone: Version 1.2
Component: email2trac Version:
Keywords: Cc:

Description

If an email with a blank subject is submitted, the following error occurs (from my syslog):

Feb 15 03:05:22 mohua email2trac: Traceback (most recent call last):
Feb 15 03:05:22 mohua email2trac:   File "/usr/bin/email2trac", line 1642, in <module>#012    tktparser.parse(sys.stdin)
Feb 15 03:05:22 mohua email2trac:   File "/usr/bin/email2trac", line 961, in parse#012    m.replace_header('Subject', m['Subject'].replace('\r', '').replace('\n', ''))
Feb 15 03:05:22 mohua email2trac: AttributeError: 'NoneType' object has no attribute 'replace'

I can't find the subject requirement documented, except obliquely (?) in response to #124.

If a site expected error output without a subject (eg some_cmd.sh | mail trac@example.org) to be handled by email2trac, this could be a nasty gotcha for them when those errors weren't turned into incoming tickets.

Testing for subject and inserting a default one would be a more graceful solution than the current exit.

Using Email2Trac $Id: email2trac.py.in 305 2010-01-11 15:09:54Z bas $

Attachments (0)

Change History (2)

comment:1 Changed 14 years ago by bas

  • Resolution set to fixed
  • Status changed from new to closed

(In [316]) Fixed a bug when there is no subject line, closes #179

comment:2 Changed 14 years ago by bas

  • Milestone set to Version 1.2

Add Comment

Modify Ticket

Change Properties
Action
as closed The owner will remain bas.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.