Modify

Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#264 closed defect (fixed)

[Patch] Workflow not identified if 'status' is in mixed case

Reported by: hju@… Owned by: bas
Priority: minor Milestone: New email2trac release 2.4.0
Component: email2trac Version: 2.1.0
Keywords: Cc:

Description

If a status is using upper case character (i.e waitingExternal) email2trac does not find the appropiate entry in the email2trac.conf

workflow_waitingExternal: dosomething

Attachments (0)

Change History (4)

comment:1 Changed 9 years ago by hju@…

This bug in ticket_update() can be fixed converting tkt['status'] to lower case (last line of the following snipped)

        ## reopen the ticket if it is was closed
        #  We must use the ticket workflow framework
        #
        if self.parameters.email_triggers_workflow and (self.VERSION >= 0.11):

            self.logger.debug('Workflow ticket update fields: ')

            from trac.ticket.default_workflow import ConfigurableTicketWorkflow
            from trac.test import Mock, MockPerm

            req = Mock(authname=self.author, perm=MockPerm(), args={})
            try:
                workflow = self.parameters['workflow_%s' %tkt['status'].lower()]

comment:2 Changed 9 years ago by bas

  • Milestone set to New email2trac release 2.X.X
  • Status changed from new to assigned

Thanks for the patch.

comment:3 Changed 9 years ago by bas

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [536]) fixed workflow problem when using mixed case chars, closes #264

comment:4 Changed 9 years ago by bas

(In [537]) forgot to save email2trac.py.in, see #264

Add Comment

Modify Ticket

Change Properties
Action
as closed The owner will remain bas.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.