Modify

Opened 12 years ago

Closed 12 years ago

#136 closed defect (fixed)

From: line misparsed when smtp_default_domain is set

Reported by: brooks@… Owned by: bas
Priority: minor Milestone: 0.90
Component: email2trac Version: 0.80
Keywords: Cc: brooks@…

Description

We've currently got (modulo real names) smtp_default_domain=trac.example.org in our configuration and that's leading to weird results. For example, if we send in a ticket request with:

From: John Doe <jdoe@example.org>

Trac sends back notices addressed to John@…, Doe@…, and jdoe@…. It seems like stripping the reporter down to just actual e-mail addresses would be the right fix in this case.

Attachments (0)

Change History (3)

comment:1 Changed 12 years ago by bas

  • Status changed from new to assigned

Which version do you use? In the current 0.9 version the author will be set to:

        self.author, self.email_addr  = email.Utils.parseaddr(self.email_from)

        # Trac can not handle author's name that contains spaces
        #
        self.author = self.email_addr 

Ah i see the reporter is set to, line 478:

ticket['reporter'] = self.email_from

can you replace it with:

ticket['reporter'] = self.email_addr

comment:2 Changed 12 years ago by bas

Did you test the fix?

comment:3 Changed 12 years ago by bas

  • Milestone set to 0.90
  • Resolution set to fixed
  • Status changed from assigned to closed

see changeset [274]

Add Comment

Modify Ticket

Change Properties
Action
as closed The owner will remain bas.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.