Identifying reporter sometime fails with bi-case email addresses

[dmcr@…]

Hi Bas,

I had a reporter who updated a ticket he had created; and since email2trac did not recognize him as the reporter, it started a new ticket (while using ticket_permission_system = update_restricted_to_participants).

It turned out to be due to the reporter sometimes using a bi-case email address, and email2trac not always using the lower() method to standardize the addresses.

The attached patch fixes this case, and other similar ones.

Best regards,

Dennis McRitchie?

[dmcr@…]

Lower-case all email addresses before comparing.

[bas]

Thanks will be applied

[bas]

(In [518]) Fixed comparison of email addresses and author names. Always do lower case comparison, closes #242

[anonymous]

fwiw, this should be an option, since it breaks RFC compliance for email.

'Fred@…' and 'fred@…' are allowed to be 2 different email addresses. (The original code only lowercases the hostname, which is explicitly not case sensitive in the RFCs: 'fred@…' and 'fred@…' ARE the same email address.)

Note: I'm not saying this new behavior shouldn't be the default, just that it'd be nice to be able to restore RFC compliance.

[dmcr@…]

It's a good point. However, the RFC states that "exploiting the case sensitivity of mailbox local-parts impedes interoperability and is discouraged". It also states: "While the above definition for Local-part is relatively permissive, for maximum interoperability, a host that expects to receive mail SHOULD avoid defining mailboxes where the Local-part requires (or uses) the Quoted-string form or where the Local-part is case-sensitive."

In this case, the "host that expects to receive mail" is the email2trac server itself, and bas might simply document that the email2trac server defines the local part as case-insensitive (as do most mail servers).

Dennis

[bas]

Thanks for all the info. Did not know that mail addresses could be case sensitive. I could make an option for it. But who uses case sensitive mail addresses?

[dmcr@…]

No internet mail provider that I know of uses a case-sensitive local-part for their email addresses. It is simply impractical. It's a wonder to me that this concept was left in the RFC, but if anyone uses this "feature", it must be in intra-net applications. Since email2trac is used in internet applications, I would recommend that you simply, clearly document that, like other internet mail providers, the email2trac server does not support case-sensitive email addresses. If someone needs the case-sensitivity, you could then add an option to provide it.

Dennis

P.S. BTW, I don't think the way email2trac was coded before my patch fully supported the RFC either. The support for case-sensitivity was inconsistent as I recall.

[bas]

I will document it and it is true and never supported this RFC ;-)